[webkit-reviews] review denied: [Bug 28272] WINCE PORT: graphics files only for WINCE : [Attachment 34769] 2) ImageWince.cpp

[bugzilla-daemon at webkit.org]

Adam Barth <abarth at webkit.org> has denied Yong Li <yong.li at torchmobile.com>'s
request for review:
Bug 28272: WINCE PORT: graphics files only for WINCE
https://bugs.webkit.org/show_bug.cgi?id=28272

Attachment 34769: 2) ImageWince.cpp
https://bugs.webkit.org/attachment.cgi?id=34769&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
+ static inline int stableRound

Why is this function WINCE specific?

+ PassRefPtr<WebCore::SharedBuffer> loadResourceIntoBuffer(const char* name);

Why are we declaring a function in a cpp file?

Also, these things should be happening in the WebCore namespace.

Aside from these minor issues, this patch actually looks somewhat reasonable. 
I'm not a graphics expert, however.