[webkit-reviews] review requested: [Bug 24731] dropEffect is always set to "copy" at dragend : [Attachment 38908] Patch with test cases

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Sep 1 20:41:21 PDT 2009


Daniel Bates <dbates at webkit.org> has asked  for review:
Bug 24731: dropEffect is always set to "copy" at dragend
https://bugs.webkit.org/show_bug.cgi?id=24731

Attachment 38908: Patch with test cases
https://bugs.webkit.org/attachment.cgi?id=38908&action=review

------- Additional Comments from Daniel Bates <dbates at webkit.org>
Fixes this issue by implementing support for DHTML drag-and-drop operations in
the Windows builds (these operations are already supported in the Mac OS X
build).

The layout tests run via Dump Render Tree (DRT) only work in the Mac OS X build
of DRT because DRT does not return the correct drop effect for a simulated
mouse click in the Windows build. This should be addressed in another bug.

However, you can manually run the layout tests and compare to the corresponding
expected file.


More information about the webkit-reviews mailing list