[webkit-reviews] review denied: [Bug 28272] WINCE PORT: graphics files only for WINCE : [Attachment 34768] 1) SharedBitmap

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Sep 1 18:45:05 PDT 2009


Adam Barth <abarth at webkit.org> has denied Yong Li <yong.li at torchmobile.com>'s
request for review:
Bug 28272: WINCE PORT: graphics files only for WINCE
https://bugs.webkit.org/show_bug.cgi?id=28272

Attachment 34768: 1) SharedBitmap
https://bugs.webkit.org/attachment.cgi?id=34768&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
+ BitmapMap g_bitmapMap

Static initializers are forbidden.

+ int discardBitmapHandles()

Functions like this should be static.

+ SharedBitmap::SharedBitmap
+ SharedBitmap::SharedBitmap

Initializer list as wrong indent.

+ SharedBitmap::~SharedBitmap

Missing blank line before this function.

+ delete[] m_pixels

Why not OwnArray?

+ memset(m_pixels, 0, bufferSize * (is16bit() ? 2 : 4));

Size calculation should be factored into an separate function.

+ void _clear()

This and its ilk are improper style.

+ explicit SharedBitmap

The explicit keyword is needed only for one-argument constructors.


More information about the webkit-reviews mailing list