[webkit-reviews] review denied: [Bug 27552] remember last script displayed in Scripts panel : [Attachment 43379] proposed patch 2009/11/17 - a
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Tue Nov 17 13:50:43 PST 2009
Timothy Hatcher <timothy at hatcher.name> has denied Patrick Mueller
<pmuellr at yahoo.com>'s request for review:
Bug 27552: remember last script displayed in Scripts panel
https://bugs.webkit.org/show_bug.cgi?id=27552
Attachment 43379: proposed patch 2009/11/17 - a
https://bugs.webkit.org/attachment.cgi?id=43379&action=review
------- Additional Comments from Timothy Hatcher <timothy at hatcher.name>
> +
> + // if not first item, check to see if this was the last viewed
> + else {
Put the comment inside the else block and remove the empty line.
> + if (url && (url == lastURL))
Remove the inner parentheses and use ===.
Otherwise r+. Nice cleanup with the options object.
More information about the webkit-reviews
mailing list