[webkit-reviews] review requested: [Bug 27552] remember last script displayed in Scripts panel : [Attachment 43379] proposed patch 2009/11/17 - a

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Nov 17 13:30:01 PST 2009


Patrick Mueller <pmuellr at yahoo.com> has asked  for review:
Bug 27552: remember last script displayed in Scripts panel
https://bugs.webkit.org/show_bug.cgi?id=27552

Attachment 43379: proposed patch 2009/11/17 - a
https://bugs.webkit.org/attachment.cgi?id=43379&action=review

------- Additional Comments from Patrick Mueller <pmuellr at yahoo.com>
Similar to previous patch, but catches more cases of the "current script" being
selected.

The last script file viewed is saved in the setting "LastViewedScriptFile". 
This is set in ScriptsPanel._showScriptOrResource(), which is the common
function used to cause a script to be displayed.  The parameters for this
function have been refactored, since it would have otherwise meant adding a
fourth parameter needed by only one call.  The "option" parameters are now
collected as properties in a single "option" parameter, and the call sites have
been changed to pass in literal objects as appropriate.


More information about the webkit-reviews mailing list