[webkit-reviews] review denied: [Bug 31553] Web Inspector: REGRESSION: in Profiles, focusing on function and restoring doesn't restore the original tree : [Attachment 43354] Proposed fix

[bugzilla-daemon at webkit.org]

Timothy Hatcher <timothy at hatcher.name> has denied Mikhail Naganov
<mnaganov at chromium.org>'s request for review:
Bug 31553: Web Inspector: REGRESSION: in Profiles, focusing on function and
restoring doesn't restore the original tree
https://bugs.webkit.org/show_bug.cgi?id=31553

Attachment 43354: Proposed fix
https://bugs.webkit.org/attachment.cgi?id=43354&action=review

------- Additional Comments from Timothy Hatcher <timothy at hatcher.name>
> +	   if (this.parent && this.parent.children.indexOf(this) >= 0) {
> +	       this._savedPosition = {
> +		   parent: this.parent,
> +		   index: this.parent.children.indexOf(this)

You should cache the result of this.parent.children.indexOf so you don't need
to do it twice.

When would you not be a child of your parent? Do you need the test.