[webkit-reviews] review denied: [Bug 31474] [V8] Protect SVG animated properties from destruction in bindings. : [Attachment 43159] patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Nov 13 08:49:26 PST 2009


Dimitri Glazkov (Google) <dglazkov at chromium.org> has denied Vitaly Repeshko
<vitalyr at chromium.org>'s request for review:
Bug 31474: [V8] Protect SVG animated properties from destruction in bindings.
https://bugs.webkit.org/show_bug.cgi?id=31474

Attachment 43159: patch
https://bugs.webkit.org/attachment.cgi?id=43159&action=review

------- Additional Comments from Dimitri Glazkov (Google)
<dglazkov at chromium.org>
> +	   //
> +	   // where PassRefPtr::~PassRefPtr() is invoked only after foo() is
> +	   // called.
> +	   template <typename T>
> +	   static PassRefPtr<T> withSVGContext(PassRefPtr<T> object,
SVGElement* context) {

Brace on new line.

> +	       setSVGContext(object.get(), context);
> +	       return object;
> +	   }
> +	   static void* withSVGContext(void* object, SVGElement* context) {

Brace on new line.

> +	       setSVGContext(object, context);
> +	       return object;

Use check-webkit-style :)


More information about the webkit-reviews mailing list