[webkit-reviews] review denied: [Bug 31473] Allow custom memory allocation control for 10 classes of the platform directory in WebCore : [Attachment 43156] proposed patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has denied Zoltan Horvath <zoltan at webkit.org>'s
request for review:
Bug 31473: Allow custom memory allocation control for 10 classes of the
platform directory in WebCore
https://bugs.webkit.org/show_bug.cgi?id=31473

Attachment 43156: proposed patch
https://bugs.webkit.org/attachment.cgi?id=43156&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
> -    class ContextMenuItem {
> +    class ContextMenuItem : public FastAllocBase {

Should be Noncopyable instead.

> -    class PlatformKeyboardEvent {
> +    class PlatformKeyboardEvent : public FastAllocBase {

I think this should be Noncopyable instead. Needs testing to be sure.

review- because we'd like keep direct FastAllocBase use to a minimum and use
Noncopyable whenever appropriate.