[webkit-reviews] review granted: [Bug 31468] Unify TextBoundaries implementations by only relying on WTF Unicode abstractions : [Attachment 43160] Refactoring TextBoundariesICU.cpp into generic TextBoundaries.cpp (v2)

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Nov 13 08:48:27 PST 2009


Darin Adler <darin at apple.com> has granted Dominik Röttsches
<dominik.roettsches at access-company.com>'s request for review:
Bug 31468: Unify TextBoundaries implementations by only relying on WTF Unicode
abstractions
https://bugs.webkit.org/show_bug.cgi?id=31468

Attachment 43160: Refactoring TextBoundariesICU.cpp into generic
TextBoundaries.cpp (v2)
https://bugs.webkit.org/attachment.cgi?id=43160&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
We normally use "using namespace" to bring in the WTF Unicode functions. See
this idiom in files such as Document.cpp, Font.cpp, and String.cpp.

This patch otherwise looks good to me.

r=me


More information about the webkit-reviews mailing list