[webkit-reviews] review denied: [Bug 20031] Implement ES 3.1 JSON object : [Attachment 30293] JSON test cases pacth

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri May 22 19:42:03 PDT 2009

Oliver Hunt <oliver at apple.com> has denied Husam Senussi <husam at senussi.com>'s
request for review:
Bug 20031: Implement ES 3.1 JSON object

Attachment 30293: JSON test cases pacth

------- Additional Comments from Oliver Hunt <oliver at apple.com>
Okay, while in general i like the tests this patch does i'd like the testcases
to use our "standard" js testcase model then tryBackend becomes
"JSON.stringify(JSON.parse(text))"), however this is optional (for now ;) )

I'd also like a few tests to cover large inputs, as well as use of the
replacement/reviver functions, specifically to test
 * which reviver functions get called; and
 * the order in which reviver functions are called

I'll r- this patch due to the additional testing that i'd like, but by and
large i like what's currently here, it just needs to be more complete.

More information about the webkit-reviews mailing list