[webkit-reviews] review denied: [Bug 25973] Avoid calling WTF::CurrentThread() from thread-local destructors in Chromium on OSX : [Attachment 30601] Proposed patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Fri May 22 19:46:55 PDT 2009
Eric Seidel <eric at webkit.org> has denied Dmitry Titov <dimich at chromium.org>'s
request for review:
Bug 25973: Avoid calling WTF::CurrentThread() from thread-local destructors in
Chromium on OSX
https://bugs.webkit.org/show_bug.cgi?id=25973
Attachment 30601: Proposed patch
https://bugs.webkit.org/attachment.cgi?id=30601&action=review
------- Additional Comments from Eric Seidel <eric at webkit.org>
Can this be tested via a layout test?
Why is it correct for chromium darwin to call CurrnetThread()?
Also some of your description from the bug belongs in teh changlog.
And a comment around your ifdef explaining what it's there for would help.
r- for the lack of test (or explanation why no test possible), and above
issues.
More information about the webkit-reviews
mailing list