[webkit-reviews] review denied: [Bug 9589] WCSS: -wap-accesskey not supported : [Attachment 30445] Latest Updated patch for code changes

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri May 22 19:41:32 PDT 2009

Eric Seidel <eric at webkit.org> has denied yichao.yin
<yichao.yin at torchmobile.com.cn>'s request for review:
Bug 9589: WCSS: -wap-accesskey not supported

Attachment 30445: Latest Updated patch for code changes

------- Additional Comments from Eric Seidel <eric at webkit.org>
Why this:
 1047	  mutable HashMap<String, Element*, CaseFoldingHash>
 1048 #else

In general this patch looks fine.  non-harmful.  The testing looks inadequate
however, see my previous comment.

I can't really approve this until there are better tests. :(

More information about the webkit-reviews mailing list