[webkit-reviews] review requested: [Bug 25928] Several errors detected by cppcheck : [Attachment 30581] Fix for cross-platform
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Fri May 22 07:47:08 PDT 2009
Alexey Proskuryakov <ap at webkit.org> has asked for review:
Bug 25928: Several errors detected by cppcheck
https://bugs.webkit.org/show_bug.cgi?id=25928
Attachment 30581: Fix for cross-platform
https://bugs.webkit.org/attachment.cgi?id=30581&action=review
------- Additional Comments from Alexey Proskuryakov <ap at webkit.org>
This patch fixes all issues affecting cross-platform code (there was only one).
Some platform issues look real, too, but I didn't feel qualified to fix them.
> [./css/CSSParser.cpp:370]: (all) Memory leak: prop
Fixed.
> [./css/CSSPrimitiveValue.cpp:79]: (all) Memory leak: colorValueCache
> [./page/DOMWindow.cpp:610]: (all) Memory leak: timer
> [./rendering/style/SVGRenderStyle.cpp:55]: (all) Memory leak: defaultStyle
These are false alarms.
More information about the webkit-reviews
mailing list