[webkit-reviews] review denied: [Bug 25961] wx port measures character widths incorrectly (Windows specific) : [Attachment 30579] Do not use GetCharABCWidths for single character measurements

[bugzilla-daemon at webkit.org]

Eric Seidel <eric at webkit.org> has denied Kevin Watters
<kevinwatters at gmail.com>'s request for review:
Bug 25961: wx port measures character widths incorrectly (Windows specific)
https://bugs.webkit.org/show_bug.cgi?id=25961

Attachment 30579: Do not use GetCharABCWidths for single character measurements
https://bugs.webkit.org/attachment.cgi?id=30579&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
Where is this code used?  Which multi-character strings does this affect?

Test case?

Also, the style is not webkit style in fontprops.cpp  Normally all code in
WebCore matches WK style, I guess we've made an exception for wx files?

Please either add a test case or update the ChangeLog to explain why one is not
possible (and if needed, file a bug requesting the additional features being
added to wx's DumpRenderTree).

Thanks for the patch!  r- for lack of test.