[webkit-reviews] review granted: [Bug 25928] Several errors detected by cppcheck : [Attachment 30581] Fix for cross-platform
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Fri May 22 07:57:27 PDT 2009
Eric Seidel <eric at webkit.org> has granted Alexey Proskuryakov <ap at webkit.org>'s
request for review:
Bug 25928: Several errors detected by cppcheck
https://bugs.webkit.org/show_bug.cgi?id=25928
Attachment 30581: Fix for cross-platform
https://bugs.webkit.org/attachment.cgi?id=30581&action=review
------- Additional Comments from Eric Seidel <eric at webkit.org>
I think the ChangeLog could be slightly clearer. To state that specifically we
would leak if we ever parsed UINT_MAX / sizeof(CSSProperty*) properties (aka ~
1billion).
Looks great though.
More information about the webkit-reviews
mailing list