[webkit-reviews] review denied: [Bug 25962] wx port lacks triple click selection : [Attachment 30580] use a timer to catch triple clicks and create PlatformMouseEvents accordingly

[bugzilla-daemon at webkit.org]

Eric Seidel <eric at webkit.org> has denied Kevin Watters
<kevinwatters at gmail.com>'s request for review:
Bug 25962: wx port lacks triple click selection
https://bugs.webkit.org/show_bug.cgi?id=25962

Attachment 30580: use a timer to catch triple clicks and create
PlatformMouseEvents accordingly
https://bugs.webkit.org/attachment.cgi?id=30580&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
Looks sane enough.

Where is the test case?  I assume Wx doesn't support DRT eventSender yet? 
Otherwise you should be able to easily write a test which tests this.

r- for the lack of test case (or lack of ChangeLog explanation for why there
isn't one).  If it's not possible to test this yet, please file a bug about
adding support to Wx's DumpRenderTree.

Otherwise the patch looks fine and I would r+ it (or anyone else should feel
free to) with the updated ChangeLog or test case.