[webkit-reviews] review denied: [Bug 24723] Use the proper definition of RETURN_PAIR on !MSVC : [Attachment 28911] patch v2

[bugzilla-daemon at webkit.org]

Gustavo Noronha (kov) <gns at gnome.org> has denied Mike Hommey
<mh+webkit at glandium.org>'s request for review:
Bug 24723: Use the proper definition of RETURN_PAIR on !MSVC
https://bugs.webkit.org/show_bug.cgi?id=24723

Attachment 28911: patch v2
https://bugs.webkit.org/attachment.cgi?id=28911&action=review

------- Additional Comments from Gustavo Noronha (kov) <gns at gnome.org>
> -// The Mac compilers are fine with this, 
> -#if PLATFORM(MAC)
> +#if PLATFORM(X86_64)

I think you want something like this here:

#if PLATFORM(X86_64) || PLATFORM(MAC)

That's because your patch will disable the usage of this struct for x86-macs,
which is not desired in my experience with similar patches.
>      struct VoidPtrPair {
>	   void* first;
>	   void* second;