[webkit-reviews] review denied: [Bug 24723] Use the proper definition of RETURN_PAIR on !MSVC : [Attachment 28911] patch v2

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sat May 9 10:20:07 PDT 2009

Gustavo Noronha (kov) <gns at gnome.org> has denied Mike Hommey
<mh+webkit at glandium.org>'s request for review:
Bug 24723: Use the proper definition of RETURN_PAIR on !MSVC

Attachment 28911: patch v2

------- Additional Comments from Gustavo Noronha (kov) <gns at gnome.org>
> -// The Mac compilers are fine with this, 
> +#if PLATFORM(X86_64)

I think you want something like this here:


That's because your patch will disable the usage of this struct for x86-macs,
which is not desired in my experience with similar patches.
>      struct VoidPtrPair {
>	   void* first;
>	   void* second;

More information about the webkit-reviews mailing list