[webkit-reviews] review granted: [Bug 24569] Add some cookies tests : [Attachment 28573] First try: includes some basic testing
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Sat May 9 14:26:35 PDT 2009
David Kilzer (ddkilzer) <ddkilzer at webkit.org> has granted Julien Chaffraix
<jchaffraix at webkit.org>'s request for review:
Bug 24569: Add some cookies tests
https://bugs.webkit.org/show_bug.cgi?id=24569
Attachment 28573: First try: includes some basic testing
https://bugs.webkit.org/attachment.cgi?id=28573&action=review
------- Additional Comments from David Kilzer (ddkilzer) <ddkilzer at webkit.org>
This is really good stuff!! r=me with a few nits:
>Index: LayoutTests/http/tests/cookies/resources/cookies-test-pre.js
>+function shouldBe(_a, _b)
>+function shouldBeEqualToString(a, b)
>+function shouldBeUndefined(_a)
>+function shouldThrow(_a, _e)
These functions should be indented by 4 spaces initially instead of just 2
spaces.
More information about the webkit-reviews
mailing list