[webkit-reviews] review granted: [Bug 25653] PLATFORM(X86_64) inherits ia64 : [Attachment 30145] fix patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sat May 9 08:09:49 PDT 2009


Gustavo Noronha (kov) <gns at gnome.org> has granted Sebastian
<webkit at ml.breakpoint.cc>'s request for review:
Bug 25653: PLATFORM(X86_64) inherits ia64
https://bugs.webkit.org/show_bug.cgi?id=25653

Attachment 30145: fix patch
https://bugs.webkit.org/attachment.cgi?id=30145&action=review

------- Additional Comments from Gustavo Noronha (kov) <gns at gnome.org>
> diff --git a/JavaScriptCore/wtf/Platform.h b/JavaScriptCore/wtf/Platform.h
> index 59f8b8f..6e4eae4 100644
> --- a/JavaScriptCore/wtf/Platform.h
> +++ b/JavaScriptCore/wtf/Platform.h
> @@ -220,7 +220,6 @@
>  
>  /* PLATFORM(X86_64) */
>  #if	 defined(__x86_64__) \
> -   || defined(__ia64__) \
>     || defined(_M_X64)
>  #define WTF_PLATFORM_X86_64 1
>  #endif
> -- 
> 1.6.2.4
> 

I'll r+ and commit this patch, since the fix is quite obvious as you said. For
future patches, please include a proper ChangeLog entry as described in
http://webkit.org/coding/contributing.html.


More information about the webkit-reviews mailing list