[webkit-reviews] review denied: [Bug 24696] Enable mixed content detection : [Attachment 30635] Patch (via client interface)

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Jun 18 17:14:35 PDT 2009


Eric Seidel <eric at webkit.org> has denied Adam Barth <abarth at webkit.org>'s
request for review:
Bug 24696: Enable mixed content detection
https://bugs.webkit.org/show_bug.cgi?id=24696

Attachment 30635: Patch (via client interface)
https://bugs.webkit.org/attachment.cgi?id=30635&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
In order to test this, you'd need to add delegate callbacks to WebKit.	Like
any other WebChromeClient.mm implementation.  These would have to be private
delegate calls, probably on the policy delegate.  And then you'd have to have
DRT's policy delegate implement them and log.

A lot of work... but mostly boiler plate, and seems like the easiest way I know
to test.

Then you'd need to add some mixed-content tests in the http tests.

r- since Olliver said above that this was blocked by lack of tests.


More information about the webkit-reviews mailing list