[webkit-reviews] review denied: [Bug 25526] [Gtk] Additional support is needed for caret browsing : [Attachment 31409] caretextra.patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Jun 18 17:12:00 PDT 2009


Eric Seidel <eric at webkit.org> has denied Xan Lopez <xan.lopez at gmail.com>'s
request for review:
Bug 25526: [Gtk] Additional support is needed for caret browsing
https://bugs.webkit.org/show_bug.cgi?id=25526

Attachment 31409: caretextra.patch
https://bugs.webkit.org/attachment.cgi?id=31409&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
Since you're adding two new execCommands we need to test those.  Please add a
LayoutTest which uses execCommand() to test these new commands.

Otherwise I think the patch looks fine.


More information about the webkit-reviews mailing list