[webkit-reviews] review requested: [Bug 26460] Cross-platform ICO decoder should return all icons in file as separate frames, sorted by decreasing quality : [Attachment 31519] part two
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Thu Jun 18 17:18:02 PDT 2009
Peter Kasting <pkasting at google.com> has asked for review:
Bug 26460: Cross-platform ICO decoder should return all icons in file as
separate frames, sorted by decreasing quality
https://bugs.webkit.org/show_bug.cgi?id=26460
Attachment 31519: part two
https://bugs.webkit.org/attachment.cgi?id=31519&action=review
------- Additional Comments from Peter Kasting <pkasting at google.com>
The next patch is going to change BMPImageReader to not inherit from
ImageDecoder, and instead change *ImageDecoder to inherit directly, and include
a BMPImageReader as a member.
Since that's a large, hard-to-review change, this patch attempts to make it
more readable by first landing as much non-functional stuff as possible to
minimize the diff. Specific items are mentioned in the ChangeLog entry, but
none should have any functional effect.
More information about the webkit-reviews
mailing list