[webkit-reviews] review cancelled: [Bug 25939] [GTK] Text attachments in bugzilla are downloaded instead of being opened : [Attachment 31233] Don't bailout if content-type is text/plain so we can setup the headers correctly
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Sat Jun 13 17:32:15 PDT 2009
Jan Alonzo <jmalonzo at gmail.com> has cancelled Jan Alonzo <jmalonzo at gmail.com>'s
request for review:
Bug 25939: [GTK] Text attachments in bugzilla are downloaded instead of being
opened
https://bugs.webkit.org/show_bug.cgi?id=25939
Attachment 31233: Don't bailout if content-type is text/plain so we can setup
the headers correctly
https://bugs.webkit.org/attachment.cgi?id=31233&action=review
------- Additional Comments from Jan Alonzo <jmalonzo at gmail.com>
Updated patch to bring back the fix in bug #24930 but only sniff once we have
the data (i.e. in the got-chunk callback) and if the content-type in the header
is text/plain. This also removes the blanket solution we're currently applying
for text/plain.
One caveat of this update is the tests I've enabled now fail. But those will be
fixed once we have the text/ media subtypes issue fixed, which is discussed in
a separate bug report.
More information about the webkit-reviews
mailing list