[webkit-reviews] review granted: [Bug 25709] Skia changes to image decoders should be merged into the cross-platform ones : [Attachment 31245] part ten

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sat Jun 13 16:51:45 PDT 2009


Eric Seidel <eric at webkit.org> has granted Peter Kasting <pkasting at google.com>'s
request for review:
Bug 25709: Skia changes to image decoders should be merged into the
cross-platform ones
https://bugs.webkit.org/show_bug.cgi?id=25709

Attachment 31245: part ten
https://bugs.webkit.org/attachment.cgi?id=31245&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
Looks good.  So many minus lines!

It's hard to see how RGBA32Buffer is different from ImageBuffer after all these
changes?  I'm starting to wonder what the design goal of RGBA32Buffer is?

Style:
 64 bool RGBA32Buffer::setSize(int new_width, int new_height)

Style:
 97 void RGBA32Buffer::setStatus(FrameStatus s)

s should really be an english word, like "status"

LGTM.


More information about the webkit-reviews mailing list