[webkit-reviews] review requested: [Bug 25939] [GTK] Text attachments in bugzilla are downloaded instead of being opened : [Attachment 31246] updated patch to sniff text/plain data too - but only once we have the data

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sat Jun 13 17:32:15 PDT 2009


Jan Alonzo <jmalonzo at gmail.com> has asked  for review:
Bug 25939: [GTK] Text attachments in bugzilla are downloaded instead of being
opened
https://bugs.webkit.org/show_bug.cgi?id=25939

Attachment 31246: updated patch to sniff text/plain data too - but only once we
have the data
https://bugs.webkit.org/attachment.cgi?id=31246&action=review

------- Additional Comments from Jan Alonzo <jmalonzo at gmail.com>
Updated patch to bring back the fix in bug #24930 but only sniff once we have
the data (i.e. in the got-chunk callback) and if the content-type in the header
is text/plain. This also removes the blanket solution we're currently applying
for text/plain. 

One caveat of this update is the tests I've enabled now fail. But those will be
fixed once we have the text/ media subtypes issue fixed, which is discussed in
a separate bug report.


More information about the webkit-reviews mailing list