[webkit-reviews] review requested: [Bug 18599] resolve-ChangeLogs doesn't work with relative paths : [Attachment 33912] Implement VCSUtils::chdirReturningRelativePath()

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Jul 31 17:36:53 PDT 2009


David Kilzer (ddkilzer) <ddkilzer at webkit.org> has asked  for review:
Bug 18599: resolve-ChangeLogs doesn't work with relative paths
https://bugs.webkit.org/show_bug.cgi?id=18599

Attachment 33912: Implement VCSUtils::chdirReturningRelativePath()
https://bugs.webkit.org/attachment.cgi?id=33912&action=review

------- Additional Comments from David Kilzer (ddkilzer) <ddkilzer at webkit.org>
Reviewed by NOBODY (OOPS!).

Step 2 to fix:
<http://webkit.org/b/18599> resolve-ChangeLogs doesn't work with relative paths

* Scripts/VCSUtils.pm:
(VCSUtils::chdirReturningRelativePath): Moved here from
chdirAndGetDifference() in svn-create-patch.
* Scripts/svn-create-patch: Switched to use
chdirReturningRelativePath() instead of chdirAndGetDifference().
(chdirAndGetDifference): Removed.
---
 3 files changed, 29 insertions(+), 13 deletions(-)


More information about the webkit-reviews mailing list