[webkit-reviews] review requested: [Bug 18599] resolve-ChangeLogs doesn't work with relative paths : [Attachment 33913] Implement VCSUtils::determineVCSRoot()

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Jul 31 17:36:56 PDT 2009


David Kilzer (ddkilzer) <ddkilzer at webkit.org> has asked  for review:
Bug 18599: resolve-ChangeLogs doesn't work with relative paths
https://bugs.webkit.org/show_bug.cgi?id=18599

Attachment 33913: Implement VCSUtils::determineVCSRoot()
https://bugs.webkit.org/attachment.cgi?id=33913&action=review

------- Additional Comments from David Kilzer (ddkilzer) <ddkilzer at webkit.org>
Reviewed by NOBODY (OOPS!).

Step 1 to fix:
<http://webkit.org/b/18599> resolve-ChangeLogs doesn't work with relative paths

* Scripts/VCSUtils.pm: Removed reference to webkitdirs module.
(VCSUtils::EXPORT): Added &determineVCSRoot.  Realphabetized.
(VCSUtils::determineGitRoot): Added.  Based on code in
commit-log-editor.
(VCSUtils::determineVCSRoot): Implemented using
determineGitRoot() and determineSVNRoot().
* Scripts/commit-log-editor: Replaced use of
topLevelSourceDirectory() with determineVCSRoot().  Resorted
use statements.
(topLevelSourceDirectory): Removed.
---
 3 files changed, 44 insertions(+), 16 deletions(-)


More information about the webkit-reviews mailing list