[webkit-reviews] review requested: [Bug 18599] resolve-ChangeLogs doesn't work with relative paths : [Attachment 33911]
resolve-ChangeLogs doesn't work with relative paths

[bugzilla-daemon at webkit.org]

David Kilzer (ddkilzer) <ddkilzer at webkit.org> has asked  for review:
Bug 18599: resolve-ChangeLogs doesn't work with relative paths
https://bugs.webkit.org/show_bug.cgi?id=18599

Attachment 33911: 
resolve-ChangeLogs doesn't work with relative paths
https://bugs.webkit.org/attachment.cgi?id=33911&action=review

------- Additional Comments from David Kilzer (ddkilzer) <ddkilzer at webkit.org>
Reviewed by NOBODY (OOPS!).

* Scripts/resolve-ChangeLogs: Used chdirReturningRelativePath()
and determineVCSRoot() to change directories to the root of the
project before running the command and to provide a path for
removeChangeLogArguments() to make sure any ChangeLog arguments
on the command line are still found.
(canonicalRelativePath): Added.  Returns a canonical path (e.g.,
stripping 'dir/../' from the path) relative to the current
directory.
(removeChangeLogArguments): Added argument which contains a
relative path that must be prepended to any ChangeLog arguments.
Used canonicalRelativePath() and File::Spec->catfile() to
construct a normalized, relative path to each file.
---
 2 files changed, 34 insertions(+), 4 deletions(-)