[webkit-reviews] review requested: [Bug 18599] resolve-ChangeLogs doesn't work with relative paths : [Attachment 33910] Add error checking to git ls-files command on close()

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Jul 31 17:36:46 PDT 2009


David Kilzer (ddkilzer) <ddkilzer at webkit.org> has asked  for review:
Bug 18599: resolve-ChangeLogs doesn't work with relative paths
https://bugs.webkit.org/show_bug.cgi?id=18599

Attachment 33910: Add error checking to git ls-files command on close()
https://bugs.webkit.org/attachment.cgi?id=33910&action=review

------- Additional Comments from David Kilzer (ddkilzer) <ddkilzer at webkit.org>
Reviewed by NOBODY (OOPS!).

Item 2 of <https://bugs.webkit.org/show_bug.cgi?id=18599#c0>.

* Scripts/resolve-ChangeLogs: Added error checking to close()
after running git ls-files.  Added error checking to all
system() calls by checking for a non-zero WEXITSTATUS($?).
Changed "|| die;" expressions to "or die $!;".
---
 2 files changed, 34 insertions(+), 15 deletions(-)


More information about the webkit-reviews mailing list