[webkit-reviews] review requested: [Bug 27167] <http://webkit.org/bugs/BUGID> bugzilla-tool: hide help for unsupported commands : [Attachment 32596] Patch v1

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Jul 10 17:51:40 PDT 2009


David Kilzer (ddkilzer) <ddkilzer at webkit.org> has asked  for review:
Bug 27167: <http://webkit.org/bugs/BUGID> bugzilla-tool: hide help for
unsupported commands
https://bugs.webkit.org/show_bug.cgi?id=27167

Attachment 32596: Patch v1
https://bugs.webkit.org/attachment.cgi?id=32596&action=review

------- Additional Comments from David Kilzer (ddkilzer) <ddkilzer at webkit.org>

Reviewed by NOBODY (OOPS!).

When bugzilla-tool -h|--help is invoked in an svn working
directory, don't print help for commands that are only supported
on git working directories.

* Scripts/bugzilla-tool:
(Command.requires_local_commits): Added.  Must be implemented by
all subclasses.
(BugsInCommitQueue.requires_local_commits): Added.
(PatchesInCommitQueue.requires_local_commits): Added.
(ReviewedPatchesOnBug.requires_local_commits): Added.
(ApplyPatchesFromBug.requires_local_commits): Added.
(LandAndUpdateBug.requires_local_commits): Added.
(LandPatchesFromBugs.requires_local_commits): Added.
(CommitMessageForCurrentDiff.requires_local_commits): Added.
(ObsoleteAttachmentsOnBug.requires_local_commits): Added.
(PostDiffAsPatchToBug.requires_local_commits): Added.
(PostCommitsAsPatchesToBug.execute): Removed
SCM.supports_local_commits() check since this is now handled by
BugzillaTool.main().
(PostCommitsAsPatchesToBug.requires_local_commits): Added.
(BugzillaTool.commands_usage): Don't print help for commands if
they require local commits and the current SCM doesn't support
them.
(BugzillaTool.main): If command_object requires local commits
and the current SCM doesn't, exit with an error message.
---
 2 files changed, 82 insertions(+), 7 deletions(-)


More information about the webkit-reviews mailing list