[webkit-reviews] review denied: [Bug 25316] Outdenting a line inside a blockquote tag does nothing : [Attachment 32540] fixes the bug

[bugzilla-daemon at webkit.org]

Eric Seidel <eric at webkit.org> has denied Ryosuke Niwa <rniwa at google.com>'s
request for review:
Bug 25316: Outdenting a line inside a blockquote tag does nothing
https://bugs.webkit.org/show_bug.cgi?id=25316

Attachment 32540: fixes the bug
https://bugs.webkit.org/attachment.cgi?id=32540&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
I think we should remove this function:
6060 static bool isIndentBlockquote(const Node* node)

and just use tag-based detection of blockquotes like was the case pre-r17143

Why is:
LayoutTests/platform/mac/editing/execCommand/outdent-selection-expected.txt
changing?  Please explain in your ChagneLog.

Please remove boilerplate from your ChangeLogs:
	 DETAILED DESCRIPTION OF THE CHANGES GOES HERE. (OOPS!) SEE:
 9	   http://webkit.org/coding/contributing.html FOR MORE INFORMATION

You soudl explain all your added tests and changes to tests in your ChangeLogs.


Please explain this change:
     if (enclosingBlockFlow != enclosingNode)
275	     splitBlockquoteNode =
splitTreeToNode(enclosingBlockFlowElement(visibleStartOfParagraph),
enclosingNode, true);
 271	     splitBlockquoteNode = splitTreeToNode(enclosingBlockFlow,
enclosingNode, true);
 272	 else {
 273	     splitElement(static_cast<Element*>(enclosingBlockFlow),
visibleStartOfParagraph.deepEquivalent().node());
 274	     splitBlockquoteNode = enclosingBlockFlow;
 275	 }
in your ChangeLog.