[webkit-reviews] review denied: [Bug 27028] [gtk] Pasteboard/GtkClipboard can't handle the "text/html" target. : [Attachment 32560] cleanup. update patch to svn r45707

[bugzilla-daemon at webkit.org]

Jan Alonzo <jmalonzo at gmail.com> has denied Jiahua Huang
<jhuangjiahua at gmail.com>'s request for review:
Bug 27028: [gtk] Pasteboard/GtkClipboard can't handle the "text/html" target.
https://bugs.webkit.org/show_bug.cgi?id=27028

Attachment 32560: cleanup.  update patch to svn r45707
https://bugs.webkit.org/attachment.cgi?id=32560&action=review

------- Additional Comments from Jan Alonzo <jmalonzo at gmail.com>
> Index: WebCore/platform/Pasteboard.h
> ===================================================================
> --- WebCore/platform/Pasteboard.h	(revision 45707)
> +++ WebCore/platform/Pasteboard.h	(working copy)
> @@ -102,6 +102,7 @@ public:
>  
>  #if PLATFORM(GTK)
>      void setHelper(PasteboardHelper*);
> +    PasteboardHelper* m_helper;
>  #endif

Is there any reason for this change?

> -    if ((gint)info == WEBKIT_WEB_VIEW_TARGET_INFO_HTML) {
> +    if ((gint)info ==
Pasteboard::generalPasteboard()->m_helper->getWebViewTargetInfoHtml()) {

I think calling generalPasteboard() is unnecessary here.

> +    virtual gint getWebViewTargetInfoHtml() const = 0;

What's this for?

Looks fine otherwise. r- for now as the patch needs to be revised.