[webkit-reviews] review granted: [Bug 26917] Increase delay in worker-terminate layout test to make it more reliable. : [Attachment 32169] Proposed patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Jul 2 09:11:01 PDT 2009


Darin Fisher (:fishd, Google) <fishd at chromium.org> has granted Dmitry Titov
<dimich at chromium.org>'s request for review:
Bug 26917: Increase delay in worker-terminate layout test to make it more
reliable.
https://bugs.webkit.org/show_bug.cgi?id=26917

Attachment 32169: Proposed patch
https://bugs.webkit.org/attachment.cgi?id=32169&action=review

------- Additional Comments from Darin Fisher (:fishd, Google)
<fishd at chromium.org>
R=me, but it sure would be nice if there were a way to construct a
test that wasn't timing sensitive.  Adding delays to the layout
tests just slows down running all of the layout tests, and if 500ms
wasn't enough, then sometimes (maybe only rarely) 1000ms will also
not be enough.


More information about the webkit-reviews mailing list