[webkit-reviews] review denied: [Bug 26882] Speed up creation of V8 wrappers for DOM nodes : [Attachment 32180] Next iteration

[bugzilla-daemon at webkit.org]

Darin Fisher (:fishd, Google) <fishd at chromium.org> has denied 's request for
review:
Bug 26882: Speed up creation of V8 wrappers for DOM nodes
https://bugs.webkit.org/show_bug.cgi?id=26882

Attachment 32180: Next iteration
https://bugs.webkit.org/attachment.cgi?id=32180&action=review

------- Additional Comments from Darin Fisher (:fishd, Google)
<fishd at chromium.org>
> Index: ChangeLog
...
> +2009-07-01  anton muhin  <antonm at chromium.org>

nit: your name should be Mixed Case


> +	   Reviewed by NOBODY (OOPS!).
> +
> +				Speed up creation of V8 wrappers for DOM nodes.

> +
> +				https://bugs.webkit.org/show_bug.cgi?id=26882

nit: please do not put tabs in the ChangeLog


> +
> +	   This patch doesn't require new tests as it a set of refactorings
> +				to speed up wrapper creation.
> +
> +	   * ../../../bindings/v8/V8Proxy.cpp:
> +	   * ../../../bindings/v8/V8Proxy.h:
> +

nit: these paths should be relative to the WebCore directory.


> Index: bindings/v8/V8Proxy.h
...
> +	   static v8::Local<v8::Object>
instantiateV8Object(V8ClassIndex::V8WrapperType descType,
V8ClassIndex::V8WrapperType cptrType, void* impl)
> +	   {
> +	     return instantiateV8Object(NULL, descType, cptrType, impl);

nit: indent by 4 spaces