[webkit-reviews] review granted: [Bug 26088] large negative letter-spacing crashes the chromium port : [Attachment 32153] revised patch w/ fishd's comments

[bugzilla-daemon at webkit.org]

Darin Fisher (:fishd, Google) <fishd at chromium.org> has granted Dirk Pranke
<dpranke at chromium.org>'s request for review:
Bug 26088: large negative letter-spacing crashes the chromium port
https://bugs.webkit.org/show_bug.cgi?id=26088

Attachment 32153: revised patch w/ fishd's comments
https://bugs.webkit.org/attachment.cgi?id=32153&action=review

------- Additional Comments from Darin Fisher (:fishd, Google)
<fishd at chromium.org>
> Index: WebCore/platform/graphics/chromium/FontChromiumWin.cpp
...
> +    // bug #26088 - init() might fail if layerRect is invalid. Given this,
...
> +	       // webkit bug 26088 - very large positive or negative runs can
fail

nit: would be nice to use a consistent way to refer to bug numbers.  no need
to say webkit since that can be assumed given that this code is part of webkit.


R=me