[webkit-reviews] review requested: [Bug 32466] Performance problems with index validation code for drawElements : [Attachment 44910] Revised patch

[bugzilla-daemon at webkit.org]

Kenneth Russell <kbr at google.com> has asked  for review:
Bug 32466: Performance problems with index validation code for drawElements
https://bugs.webkit.org/show_bug.cgi?id=32466

Attachment 44910: Revised patch
https://bugs.webkit.org/attachment.cgi?id=44910&action=review

------- Additional Comments from Kenneth Russell <kbr at google.com>
Changed int variables in WebGLBuffer::setCachedMaxIndex to size_t.

Split complex if statement in WebGLRenderingContext::drawElements into a few
separate ifs.

Refactored JavaScript code in ManyPlanetsDeep into ManyPlanetsDeep.js. I tried
sourcing ManyPlanetsDeep.html as an iframe but the computation of the canvas's
size broke, so this was the most easily achievable refactoring.

I left the caching code as is. The current code is not that complex and is
future-proof.