[webkit-reviews] review denied: [Bug 5578] WebKit does not support DOM Level 3 setIsId and isId : [Attachment 44892] minor change

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has denied Chang Shu <Chang.Shu at nokia.com>'s
request for review:
Bug 5578: WebKit does not support DOM Level 3 setIsId and isId
https://bugs.webkit.org/show_bug.cgi?id=5578

Attachment 44892: minor change
https://bugs.webkit.org/attachment.cgi?id=44892&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
> +    return qualifiedName().matches(m_element ? m_element->idAttributeName()
: HTMLNames::idAttr);

Normally we'd put "using namespace HTMLNames" at the top of the file rather
than qualifying idAttr with it here.

> +    , m_idAttributeName(HTMLNames::idAttr)

Same here.

> Index: WebCore/rendering/RenderLayerBacking.cpp
> ===================================================================
> --- WebCore/rendering/RenderLayerBacking.cpp	(revision 52092)
> +++ WebCore/rendering/RenderLayerBacking.cpp	(working copy)
> @@ -86,7 +86,7 @@ void RenderLayerBacking::createGraphicsL
>	       m_graphicsLayer->setName("Document Node");
>	   else {
>	       if (renderer()->node()->isHTMLElement() &&
renderer()->node()->hasID())
> -		   m_graphicsLayer->setName(renderer()->renderName() + String("
") + static_cast<HTMLElement*>(renderer()->node())->getAttribute(idAttr));
> +		   m_graphicsLayer->setName(renderer()->renderName() + String("
") +
static_cast<HTMLElement*>(renderer()->node())->getAttribute(idAttributeName()))
;

I don't think this will compile. RenderLayerBacking does not have an
idAttributeName() member function.

> -	  setImplementationAttribute("validating", true);
> +	// Remove the following line otherewise test case skipped.
> +	//setImplementationAttribute("validating", true);

Typo: "otherewise".

Should mention this is a WebKit change as I said last time.

> -	  setImplementationAttribute("validating", true);
> +	// Remove the following line otherewise test case skipped.
> +	//setImplementationAttribute("validating", true);

Same typo.

review- because of the broken build of RenderLayerBacking.cpp