[webkit-reviews] review granted: [Bug 32261] Add ability to specify suggested autocomplete value in HTMLInputElement : [Attachment 44840] Added ability to separate autocomplete suggestion previewing from accepting of the suggested value in HTMLInputElement / RenderTextControlSingleLine

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Dec 15 14:24:43 PST 2009


Darin Adler <darin at apple.com> has granted Zelidrag Hornung
<zelidrag at chromium.org>'s request for review:
Bug 32261: Add ability to specify suggested autocomplete value in
HTMLInputElement
https://bugs.webkit.org/show_bug.cgi?id=32261

Attachment 44840: Added ability to separate autocomplete suggestion previewing
from accepting of the suggested value in HTMLInputElement /
RenderTextControlSingleLine
https://bugs.webkit.org/attachment.cgi?id=44840&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
> +    String suggestedValue() const { return m_suggestedValue; }

I know that the value() function doesn't do it this way, but you can save a
tiny bit of reference count churn by making the return type be const String&
instead of String.

I believe this will break the WML build, because you're adding a new virtual
function that WMLInputElement doesn't implement.

I really wish there was a way to expose and test this new feature, but since
the whole idea is to hide it from JavaScript, I can't think of any better way
do things.

r=me


More information about the webkit-reviews mailing list