[webkit-reviews] review granted: [Bug 32529] Rename skipCanLoadCheck to skipSecurityCheck : [Attachment 44909] patch3 - reordered SecurityCheck enum

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Dec 15 14:09:49 PST 2009


Darin Adler <darin at apple.com> has granted Nate Chapin <japhet at chromium.org>'s
request for review:
Bug 32529: Rename skipCanLoadCheck to skipSecurityCheck
https://bugs.webkit.org/show_bug.cgi?id=32529

Attachment 44909: patch3 - reordered SecurityCheck enum
https://bugs.webkit.org/attachment.cgi?id=44909&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
This is great. r=me

Next time we name a type like this, we should consider how the type name works
conceptually. The type is named SecurityCheck, yet the object is not a security
check. It's a decision about whether security checks should be performed. I
think I would have called the type SecurityCheckPolicy.


More information about the webkit-reviews mailing list