[webkit-reviews] review granted: [Bug 23846] [GTK]Enable DNS prefetching : [Attachment 43782] dnsprefetch.diff

[bugzilla-daemon at webkit.org]

Gustavo Noronha (kov) <gns at gnome.org> has granted Xan Lopez
<xan.lopez at gmail.com>'s request for review:
Bug 23846: [GTK]Enable DNS prefetching
https://bugs.webkit.org/show_bug.cgi?id=23846

Attachment 43782: dnsprefetch.diff
https://bugs.webkit.org/attachment.cgi?id=43782&action=review

------- Additional Comments from Gustavo Noronha (kov) <gns at gnome.org>
>  #include "config.h"
> +#include "CString.h"
>  #include "DNS.h"
> -
> -#include "NotImplemented.h"
> +#include "ResourceHandle.h"

As pointed out by the review queue, the CString.h header should be just before
ResourceHandle.h, and there should indeed be a blank line between #include
"DNS.h" and the CString include.

>  void prefetchDNS(const String& hostname)
>  {
> -    notImplemented();
> +    String uri = "http://"+hostname;
> +    SoupURI* soupUri = soup_uri_new(uri.utf8().data());
> +    soup_session_prepare_for_uri(ResourceHandle::defaultSession(), soupUri);

> +    soup_uri_free(soupUri);
>  }

How about using GOwnPtr here? r=me with whatever you decide in this regard, and
with the style problems fixed.