[webkit-reviews] review denied: [Bug 32024] [GTK] WebKit does not compile without JAVASCRIPT_DEBUGGER : [Attachment 44126] patch with Changelog
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Wed Dec 2 10:26:30 PST 2009
Gustavo Noronha (kov) <gns at gnome.org> has denied Gyuyoung Kim
<gyuyoung at gmail.com>'s request for review:
Bug 32024: [GTK] WebKit does not compile without JAVASCRIPT_DEBUGGER
https://bugs.webkit.org/show_bug.cgi?id=32024
Attachment 44126: patch with Changelog
https://bugs.webkit.org/attachment.cgi?id=44126&action=review
------- Additional Comments from Gustavo Noronha (kov) <gns at gnome.org>
Hrm. Yeah, I think the case statements should indeed be outside the #if
clauses, because it would be kind of an API breakage otherwise, but you should
perhaps add a g_message to the #else case, and make sure get_property already
sets false to the value, just to be sure.
More information about the webkit-reviews
mailing list