[webkit-reviews] review denied: [Bug 31990] [GTK] Recognize oga as audio/ogg : [Attachment 44059] advertize audio/ogg correctly

[bugzilla-daemon at webkit.org]

Gustavo Noronha (kov) <gns at gnome.org> has denied Philippe Normand
<pnormand at igalia.com>'s request for review:
Bug 31990: [GTK] Recognize oga as audio/ogg
https://bugs.webkit.org/show_bug.cgi?id=31990

Attachment 44059: advertize audio/ogg correctly
https://bugs.webkit.org/attachment.cgi?id=44059&action=review

------- Additional Comments from Gustavo Noronha (kov) <gns at gnome.org>
(In reply to comment #8)
> (In reply to comment #7)
> Well I can update media/video-can-play-type.html and add checks for audio/ogg

> and video/ogg but I'm afraid this would fail on mac for instance. Generally
> this depends on the platform and if codecs are installed for the given
> mime-type, it's not a trivial scenario.

I have a number of recomendations regarding this:

First of all, I think we should refactor this code following this
recommendation:

Nov 05 14:32:29 <slomo> kov: get the GstStructure(s) from them, use the
gst_structure_* API :)

Perhaps you want to write that patch? As for how to test, I would recommend
adding a separate test similar to media/video-can-play-type.html, and add it to
the Skipped file for all platforms that are not supposed to pass it right now.
I'll say r- for now.