[webkit-reviews] review granted: [Bug 28802] Remove ASSERT(frame) in ResourceHandle::start (ResourceHandleCurl.cpp) : [Attachment 38726] Remove ASSERT(frame)

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Aug 31 03:32:36 PDT 2009

Eric Seidel <eric at webkit.org> has granted Kwang Yul Seo
<kwangyul.seo at gmail.com>'s request for review:
Bug 28802: Remove ASSERT(frame) in ResourceHandle::start

Attachment 38726: Remove ASSERT(frame)

------- Additional Comments from Eric Seidel <eric at webkit.org>
Mac has:
    if (!frame)
	return false;

Win does:
    // If we are no longer attached to a Page, this must be an attempted load
from an
    // onUnload handler, so let's just block it.
    if (!frame->page())
	return false;

Somebody is wrong here.  I'll CC bradee.

More information about the webkit-reviews mailing list