[webkit-reviews] review granted: [Bug 28808] [Skia] Fix flaky layout test svg/dynamic-updates/SVGClipPathElement-dom-clipPathUnits-attr.html [DEBUG] : [Attachment 38733] patch: check skia safety of path on conversion to local coordinates

[bugzilla-daemon at webkit.org]

Eric Seidel <eric at webkit.org> has granted Roland Steiner
<rolandsteiner at google.com>'s request for review:
Bug 28808: [Skia] Fix flaky layout test
svg/dynamic-updates/SVGClipPathElement-dom-clipPathUnits-attr.html [DEBUG]
https://bugs.webkit.org/show_bug.cgi?id=28808

Attachment 38733: patch: check skia safety of path on conversion to local
coordinates
https://bugs.webkit.org/attachment.cgi?id=38733&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
Looks fine.

+extern bool isPathSkiaSafe(const SkMatrix& transform, const SkPath& path);
should not have names for the arguments since they don't add anything.

Not sure why you're moving the inline functions around... I guess so you can
export a function?

If we're going to export the function we should just add it to a header no?  Or
to some utility file?

This looks OK.	Waiting for your response or new patch before landing.