[webkit-reviews] review denied: [Bug 28791] [Chromium] Space bar and enter should open drop-down menus on Linux : [Attachment 38703] Look for PLATFORM(GTK) || (PLATFORM(CHROMIUM) && PLATFORM(LINUX)) when deciding whether to use the GTK behavior.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Aug 31 03:37:18 PDT 2009


Eric Seidel <eric at webkit.org> has denied Albert Bachand <albertb at google.com>'s
request for review:
Bug 28791: [Chromium] Space bar and enter should open drop-down menus on Linux
https://bugs.webkit.org/show_bug.cgi?id=28791

Attachment 38703: Look for PLATFORM(GTK) || (PLATFORM(CHROMIUM) &&
PLATFORM(LINUX)) when deciding whether to use the GTK behavior.
https://bugs.webkit.org/attachment.cgi?id=38703&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
Change looks good.  ChangeLog was generated with funny paths, not sure why.

We need at least a manual test for this:  WebCore/manual-tests/

An automated test in LayoutTests/ would be better.  It's definitely possible to
send a space key event using eventSender, I'm not sure if it's possible to
detect that a popup opened up from JavaScript though.


More information about the webkit-reviews mailing list