[webkit-reviews] review canceled: [Bug 28036] [Qt] Public API to configure the storage path for HTML5 localStorage : [Attachment 34448] second try

[bugzilla-daemon at webkit.org]

Laszlo Gombos <laszlo.1.gombos at nokia.com> has canceled Laszlo Gombos
<laszlo.1.gombos at nokia.com>'s request for review:
Bug 28036: [Qt] Public API to configure the storage path for HTML5 localStorage
https://bugs.webkit.org/show_bug.cgi?id=28036

Attachment 34448: second try
https://bugs.webkit.org/attachment.cgi?id=34448&action=review

------- Additional Comments from Laszlo Gombos <laszlo.1.gombos at nokia.com>
Additional changes in the 3rd revision of the patch:
 - LocalStorageDatabaseEnabled enum value is now deprecated, the new name is
LocalStorageEnabled
 - LocalStoragePath now has a default (<base path>/LocalStorage/)

Here are some reasons to keep the LocalStorage name (instead of switching to
WebStorage).
 - The LocalStorageEnabled setting does not control SessionStorage and as such
WebStorageEnabled name would be misleading
 - WebStorage is indeed the name of the specification, but the relevant JS
interface is called window.localStrorage - I believe the JS interface name is
equally/more relevant 
 - WebStorage spec is referenced not only in the HTML5 spec but also in Widgets
APIs and Events spec (see http://www.w3.org/TR/widgets-apis,
widget.preferences). Since the interface that is defined in this patch is only
for the HTML5 LocalStorage I think the name of the interface should be also
specific to HTML5 to distinguish it from other WebStorage use-cases