[webkit-reviews] review requested: [Bug 27889] [Chromium] RTL autocomplete popup is not layout correctly. : [Attachment 34536] patch w/ manual test
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Mon Aug 10 19:36:16 PDT 2009
Xiaomei Ji <xji at chromium.org> has asked for review:
Bug 27889: [Chromium] RTL autocomplete popup is not layout correctly.
https://bugs.webkit.org/show_bug.cgi?id=27889
Attachment 34536: patch w/ manual test
https://bugs.webkit.org/attachment.cgi?id=34536&action=review
------- Additional Comments from Xiaomei Ji <xji at chromium.org>
updated patch per Jay and Mitz's suggestions:
1. add a new flag to indicate in what directionality text in popup will be
drawn.
2. move draw ellispses with draw truncated text from PopupMenuChromium to
GraphicsContext
3. use StringTruncator to prepare truncated text along with ellipses to be
drawn.
More information about the webkit-reviews
mailing list