[webkit-reviews] review requested: [Bug 21248] Support placeholder on textarea : [Attachment 34534] Proposed patch (rev.4)
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Mon Aug 10 19:11:12 PDT 2009
TAMURA, Kent <tkent at chromium.org> has asked for review:
Bug 21248: Support placeholder on textarea
https://bugs.webkit.org/show_bug.cgi?id=21248
Attachment 34534: Proposed patch (rev.4)
https://bugs.webkit.org/attachment.cgi?id=34534&action=review
------- Additional Comments from TAMURA, Kent <tkent at chromium.org>
Sorry for the large patch.
* The most of changes in HTMLInputElment, InputElment, WMLInputElement are
trivial. (removal of unused parameters)
* We have a bug about maxlength. The patch accidentally fixes it because of
RenderTextControlSingleLine::updateFromElement() change.
input-text-maxlength-expected.txt had wrong expected data.
More information about the webkit-reviews
mailing list