[webkit-reviews] review canceled: [Bug 27966] Race condition in the database code : [Attachment 34512] same patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Aug 10 19:23:56 PDT 2009


Dumitru Daniliuc <dumi at chromium.org> has canceled Dumitru Daniliuc
<dumi at chromium.org>'s request for review:
Bug 27966: Race condition in the database code
https://bugs.webkit.org/show_bug.cgi?id=27966

Attachment 34512: same patch
https://bugs.webkit.org/attachment.cgi?id=34512&action=review

------- Additional Comments from Dumitru Daniliuc <dumi at chromium.org>
Addressed Michael's comments. Also, Michael suggested that it might be better
to make SQLTransaction::lockAcquire() schedule an immediate task on the DB
thread for SQLTransaction::openTransactionAndPreflight(), instead of directly
calling this method. I agreed and made this change too, by adding a bool
parameter to Database::scheduleTransactionStep() that defaults to false (true =
scheduleImmediateTask(), false = scheduleTask()).


More information about the webkit-reviews mailing list