[webkit-reviews] review denied: [Bug 27719] [Chromium] Regression in r42671 - js event object being hidden. : [Attachment 34522] patch2 - Fixed DOMWindow.idl and cleaned up logic in CodeGeneratorV8.pm

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Aug 10 18:54:20 PDT 2009


Adam Barth <abarth at webkit.org> has denied Nate Chapin <japhet at chromium.org>'s
request for review:
Bug 27719: [Chromium] Regression in r42671 - js event object being hidden.
https://bugs.webkit.org/show_bug.cgi?id=27719

Attachment 34522: patch2 - Fixed DOMWindow.idl and cleaned up logic in
CodeGeneratorV8.pm
https://bugs.webkit.org/attachment.cgi?id=34522&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
You should test what happens when you set window.event to null.  Currently,
you're changing the setter but not actually testing it!

Also, I'm skeptical that we should grab CurrentContext in the setter. 
Shouldn't we grab the window that the setter is being called on?


More information about the webkit-reviews mailing list